Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] Fix static builds relying on the docker-* prefix #241

Merged
merged 2 commits into from
Sep 26, 2018
Merged

[18.09] Fix static builds relying on the docker-* prefix #241

merged 2 commits into from
Sep 26, 2018

Conversation

seemethere
Copy link
Contributor

Backport of #240

andrewhsu and others added 2 commits September 26, 2018 18:57
@andrewhsu @seemethere
rename binaries to remove docker prefix
43ebdc0 
For static builds.

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere
containerd-ctr -> ctr
7590605 
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere seemethere added the backport Backports to release branches label Sep 26, 2018
@seemethere seemethere requested review from andrewhsu, tiborvass, dhiltgen and a team September 26, 2018 18:59
@seemethere seemethere mentioned this pull request Sep 26, 2018
Closed
jose-bigio
jose-bigio approved these changes Sep 26, 2018
View reviewed changes
Copy link

@jose-bigio jose-bigio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere seemethere merged commit 6a38ee2 into docker:18.09 Sep 26, 2018
@mattpag mattpag mentioned this pull request Jul 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-bigio jose-bigio jose-bigio approved these changes

@dhiltgen dhiltgen dhiltgen approved these changes

@andrewhsu andrewhsu Awaiting requested review from andrewhsu

@tiborvass tiborvass Awaiting requested review from tiborvass

Assignees
No one assigned
Labels
backport Backports to release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seemethere @dhiltgen @jose-bigio @andrewhsu